On 8 March 2016 at 07:36, Peter Xu <pet...@redhat.com> wrote: > v4 changes: > - all: rename query-gic-capability to query-gic-capabilities [Andrea] > - patch 3: rename helper function to kvm_support_device, make it > inline and lighter. [Drew] > > v3 changes: > - patch 2: remove func declaration, add qmp header [Drew] > - patch 3: being able to detect KVM GIC capabilities even without > kvm enabled [Andrea]: this is a little bit hacky, need some more > review on this. > > v2 changes: > - result layout change: use array and dict for the capability bits > rather than a single array of strings [Andrea/Markus] > - spelling out what GIC is in doc [Eric] > > This patch is to add ARM-specific command "query-gic-capability". > > The new command can report which kind of GIC device the host/QEMU > support. The returned result is in the form of array.
Hi. I've made some code review comments on the specifics of the implementation, but really what I'd like to see is: * an ack from the libvirt folks that this API meets their requirements * an ack/review frem Eric or somebody else familiar with qmp that it's OK from a protocol perspective since I'm not really able to judge those aspects. thanks -- PMM