Eric Blake <ebl...@redhat.com> writes: > Rather than having two separate visitor callbacks with items > already broken out, pass the actual QAPISchemaObjectType object > to the visitor. This lets the visitor access things like > type.is_implicit() without needing another parameter, resolving > a TODO from previous patches. > > For convenience and consistency, the 'name' and 'info' parameters > are still provided, even though they are now redundant with > 'typ.name' and 'typ.info'. > > Signed-off-by: Eric Blake <ebl...@redhat.com>
$ for i in `git-ls-files tests/qapi-schema/\*.out`; do diff -q $i bld-x86/${i%.out}.test.out; done Files tests/qapi-schema/comments.out and bld-x86/tests/qapi-schema/comments.test.out differ Files tests/qapi-schema/empty.out and bld-x86/tests/qapi-schema/empty.test.out differ Files tests/qapi-schema/event-case.out and bld-x86/tests/qapi-schema/event-case.test.out differ Files tests/qapi-schema/ident-with-escape.out and bld-x86/tests/qapi-schema/ident-with-escape.test.out differ Files tests/qapi-schema/include-relpath.out and bld-x86/tests/qapi-schema/include-relpath.test.out differ Files tests/qapi-schema/include-repetition.out and bld-x86/tests/qapi-schema/include-repetition.test.out differ Files tests/qapi-schema/include-simple.out and bld-x86/tests/qapi-schema/include-simple.test.out differ Files tests/qapi-schema/indented-expr.out and bld-x86/tests/qapi-schema/indented-expr.test.out differ Files tests/qapi-schema/qapi-schema-test.out and bld-x86/tests/qapi-schema/qapi-schema-test.test.out differ > --- > v6: new patch Let's punt this one to a later iteration.