On 03/15/2016 07:27 PM, Paolo Bonzini wrote:
On 13/03/2016 12:40, Marcel Apfelbaum wrote:
According to the ACPI spec, each UID must be unique.
Use the irq number as UID for GSI links.
Suggested-by: Michael S. Tsirkin <m...@redhat.com>
Signed-off-by: Marcel Apfelbaum <mar...@redhat.com>
This causes a warning from acpi-test. The diff is
2720c2720
< Name (_UID, Zero) // _UID: Unique ID
---
Name (_UID, 0x10) // _UID: Unique ID
2747c2747
< Name (_UID, Zero) // _UID: Unique ID
---
Name (_UID, 0x11) // _UID: Unique ID
2774c2774
< Name (_UID, Zero) // _UID: Unique ID
---
Name (_UID, 0x12) // _UID: Unique ID
2801c2801
< Name (_UID, Zero) // _UID: Unique ID
---
Name (_UID, 0x13) // _UID: Unique ID
2828c2828
< Name (_UID, Zero) // _UID: Unique ID
---
Name (_UID, 0x14) // _UID: Unique ID
2855c2855
< Name (_UID, Zero) // _UID: Unique ID
---
Name (_UID, 0x15) // _UID: Unique ID
2882c2882
< Name (_UID, Zero) // _UID: Unique ID
---
Name (_UID, 0x16) // _UID: Unique ID
2909c2909
< Name (_UID, Zero) // _UID: Unique ID
---
Name (_UID, 0x17) // _UID: Unique ID
I think you should have updated tests/acpi-test-data.
Thanks Paolo, you are right.
I am "used to" Michael updating the test data on his pull request.
I can send an update myself, it will have to wait a few days.
Thanks,
Marcel
Paolo
