Am 16.03.2016 um 15:11 schrieb Peter Maydell: > If qdev_try_create() is passed NULL for the bus, it will automatically > put the newly created device onto the default system bus. However > if the device is not actually a SysBusDevice then this will result > in later crashes (for instance when running the monitor "info qtree" > command) because code reasonably assumes that all devices on the system > bus are system bus devices. > > Generally the mistake is that the calling code should create the > object with object_new(TYPE_FOO) rather than qdev_create(NULL, TYPE_FOO); > see commit 6749695eaaf346c1 for an example of fixing this bug. > > Assert in qdev_try_create() if the device isn't suitable to put on > the system bus, so that this mistake results in failure earlier > and more reliably. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > This needs to go in after http://patchwork.ozlabs.org/patch/597716/ > as otherwise the bug fixed by that patch will become a 'make check' > failure.
Looks strange, but okay, Reviewed-by: Andreas Färber <afaer...@suse.de> Through whose queue? Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)