Hello, One more thing I noticed was that there is no function prototype for the function get_ticks_per_sec().
I was planning to use a script to change all the used of get_ticks_per_sec() to NANOSECONDS_PER_SECOND with an exception of the function definition itself in include/qemu/timer.h. SO wanted to know if there is a function prototype that should also be skipped. On Mon, Mar 21, 2016 at 7:39 PM, haris iqbal <haris.p...@gmail.com> wrote: > On Mon, Mar 21, 2016 at 7:26 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: >> >> >> On 21/03/2016 14:41, haris iqbal wrote: >>> Hello, >>> >>> I saw a task which says to " Add checks for NULL return value to uses >>> of load_image_targphys,...". But what I saw in the codebase, >>> load_image_targphys() returns int. So why should it be checks for >>> NULL. >> >> You're right, in the case of load_image_targphys the error value is -1. >> I've fixed the wiki page. > > > Thanks. > >> >> Paolo > > > > -- > > With regards, > > Md Haris Iqbal, > Placement Coordinator, MTech IT > NITK Surathkal, > Contact: +91 8861996962 -- With regards, Md Haris Iqbal, Placement Coordinator, MTech IT NITK Surathkal, Contact: +91 8861996962
