On 03/23/2016 04:12 PM, Markus Armbruster wrote:
Cao jin <caoj.f...@cn.fujitsu.com> writes:
Really appreciate your review, I just finished reading all the
comments and discussion.
Seems pci_add_capability2()(commit cd9aa33e introduced) doesn`t follow
the new error reporting rule(report error while also return error).
Misunderstanding?
"Report an error to the user" means error_report() and such.
error_setg() doesn't report to the user, it returns an error object to
the caller.
ah...thanks for correcting me.
So I am thinking, could we revert commit cd9aa33e, let
pci_add_capability() return error code and assert when out of pci
space, and let caller(only assigned device, others could ignore the
error) handle the error code(new a error object, propagate it)
Hope to hear PCI Maintainer`s advice(So I don`t cc other in this round)
--
Yours Sincerely,
Cao jin
