On Wed, Mar 23, 2016 at 10:44:04AM +0100, Markus Armbruster wrote: > Depends. > > The general rule is to keep separate things separate, and patches > self-contained. The narrow sense of self-contained is each patch > compiles and works. The wider sense is each patch makes sense to its > readers on its own. You can't always have a perfect score on the > latter, but you should try. > > Adding a definition without a user is generally not advised, because you > generally need to see the user to make sense of it. > > For a complex feature, adding its abstract interface before its concrete > implementation may help liberate interface review from implementation > details. > > Note that your interface consists of type GICCapability and command > query-gic-capabilities. You could add just the interface with a stub > implementation first, then flesh out the implementation. But I doubt > the thing is complex enough to justify that.
Thanks for the thorough explaination on this. It's indeed not easy to figure out the best way every time for me... Now I do feel it strange to split the first patch alone from the 2nd one. Anyway, it's squashed into the 2nd patch in v6. -- peterx
