On 03/23/2016 11:12 AM, Peter Maydell wrote: > On 17 March 2016 at 13:25, Shannon Zhao <zhaoshengl...@huawei.com> wrote: >> From: Shannon Zhao <shannon.z...@linaro.org> >> >> There is a problem for power button that it will not work if an early >> system_powerdown request happens before guest gpio driver loads. >> >> Here we add the emulation of gpio_key and use it for ARM virt power >> button. > > I tweaked the type names to be 'gpio-key' rather than 'gpio_key', > and added a comment to briefly describe what the device does: > > + * Emulate a (human) keypress -- when the key is triggered by > + * setting the incoming gpio line, the outbound irq line is > + * raised for 100ms before being dropped again. > > Applied to target-arm.next, thanks.
I didn't see the patch series until yesterday. So just to make it complete, I did test it with both DT and ACPI modes. The patch seemed to work as intended. Tested-by: Wei Huang <w...@redhat.com> Thanks, -Wei > > -- PMM >
