On 03/20/2016 08:43 AM, Veronia wrote: > move declarations out of qemu-common.h for functions declared in > utils/ files: e.g. include/qemu/path.h for utils/path.c. > move inline functions out of qemu-common.h and into new files (e.g. > include/qemu/bcd.h) > > Signed-off-by: Veronia Bahaa<veronia@veroniaba...@gmail.com>
Space before <. 'git commit -s' (or 'git commit --amend -s' on an existing commit) will space things correctly if your ~/.gitconfig is correct; if you are typing the S-o-b by hand, I recommend figuring out how to get git to do it for you. > --- > 161 files changed, 439 insertions(+), 320 deletions(-) > create mode 100644 include/qemu/bcd.h > create mode 100644 include/qemu/cutils.h > create mode 100644 include/qemu/help_option.h > create mode 100644 include/qemu/id.h > create mode 100644 include/qemu/path.h > create mode 100644 include/qemu/unicode.h This is a big patch. To make review easier, I highly suggest that you repost this as a series of (at least) 6 patches, one per file (if any one include file is huge, it might help to further break it down into 2-3 related functions per patch rather than all functions belonging to the file). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
