On Wed, 30 Mar 2016 15:30:04 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote:
> On 30/03/2016 15:23, Cornelia Huck wrote: > > > There is no need to run the handler one last time; the device is being > > > reset and it is okay to drop requests that are pending in the virtqueue. > > > > What about virtio_blk_save()? Could there be any pending requests in > > that case? > > Those would be processed when dataplane is restarted on the destination > side, I think. virtio_queue_set_host_notifier_fd_handler calls > virtio_queue_host_notifier_read which connects the host notifier to the > I/O thread and calls event_notifier_set to start processing it. Makes sense; maybe mention that in the patch description as well?