On Wed, Mar 30, 2016 at 05:51:16PM +0200, Max Reitz wrote: > On 30.03.2016 15:53, Daniel P. Berrange wrote: > > The LUKS block driver tests will require the ability to specify > > encryption secrets with block devices. This requires using the > > --object argument to qemu-img/qemu-io to create a 'secret' > > object. > > > > When the IMGKEYSECRET env variable is set, it provides the > > password to be associated with a secret called 'keysec0' > > > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > tests/qemu-iotests/common | 1 + > > tests/qemu-iotests/common.config | 6 ++++++ > > tests/qemu-iotests/common.filter | 3 ++- > > tests/qemu-iotests/common.rc | 16 +++++++++++++--- > > 4 files changed, 22 insertions(+), 4 deletions(-) > > Is there a reason why you didn't implement the same logic in > _qemu_img_wrapper as in _qemu_io_wrapper?
Mostly because the --image-opts syntax isn't used with the 'create' command for qemu-img. I guess I could have trie to detect which command was being run and set the args accordingly. > This works, but it appears a bit overcomplicated to me. > > Reviewed-by: Max Reitz <mre...@redhat.com> Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
