On Mon, 21 Jun 2010 10:27:11 +0200 Markus Armbruster <arm...@redhat.com> wrote:
> Luiz Capitulino <lcapitul...@redhat.com> writes: > > > On Fri, 18 Jun 2010 15:28:42 -0500 > > Anthony Liguori <anth...@codemonkey.ws> wrote: > > > >> On 06/18/2010 11:26 AM, Miguel Di Ciurcio Filho wrote: > >> > These commands show the information about active backend network devices. > >> > > >> > Signed-off-by: Miguel Di Ciurcio Filho<miguel.fi...@gmail.com> > >> > --- > >> > qemu-monitor.hx | 105 > >> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > >> > 1 files changed, 105 insertions(+), 0 deletions(-) > >> > > >> > diff --git a/qemu-monitor.hx b/qemu-monitor.hx > >> > index 9f62b94..8fc5ed6 100644 > >> > --- a/qemu-monitor.hx > >> > +++ b/qemu-monitor.hx > >> > @@ -1674,6 +1674,111 @@ show the various VLANs and the associated devices > >> > ETEXI > >> > > >> > STEXI > >> > +...@item info netdev > >> > +show information about the current backend network devices > >> > +ETEXI > >> > +SQMP > >> > +query-netdev > >> > +------------ > >> > + > >> > +Each device is represented by a json-object. The returned value is a > >> > json-array > >> > +of all devices. > >> > + > >> > +Each json-object contains the following: > >> > + > >> > +- "id": the device's ID, must be unique (json-string) > >> > +- "type": device type (json-string) > >> > + - Possible values: "tap", "user", "vde", "socket" > >> > +- "vlan": QEMU's internal vlan identification. Only present if the > >> > device is > >> > + attached to a VLAN (json-int, optional) > >> > +- "peer": ID of the frontend device when on a 1:1 relationship > >> > (json-string, > >> > + optional) > >> > > >> > >> I think we should only return items with a valid peer property and drop > >> anything attached to vlans. > > > > The reason is that we're going to completely drop the vlan stuff, right? > > > >> The current info network already provides vlan information. > > > > What did you mean by that? info network is not going to be converted to > > QMP, > > that's why we're doing query-netdev. > > If we want to cover VLANs in QMP, we can either cover them in > query-netdev, or provide a separate query, say query-vlans. The latter > has the advantage that we won't have to mess with query-netdev when we > get rid of VLANs. > > In my personal opinion, we should just ditch VLANs and be done with it. Agreed. > > > If I got it right: > > > > - query-netdev: backend info > > - query-qdm: device info > > I think you mean query-qtree. query-qdm is about available device > models. Yes.