Le 22 avr. 2016 à 13:22, Andrew Baumann <andrew.baum...@microsoft.com> a écrit : >> + stl_le_phys(&s->dma_as, value + 16, tmp_xres * tmp_yres * >> + (tmp_bpp >> 3)); > > Personal style nit: I prefer * 8 rather than >> 3, because it's more > immediately obvious what you're computing, a trivial optimisation for the > compiler, and in this specific example wouldn't need the brackets to ensure > the correct operator precedence. > > But in any case, > Reviewed-by: Andrew Baumann <andrew.baum...@microsoft.com>
Thanks! It is actually / 8, but I used >> 3 to remain consistent with what I read in hw/display/bcm2835_fb.c. Feel free to adapt.
