On 04/27/2016 08:29 AM, Markus Armbruster wrote: > replay_configure() pushes and pops a Location with automatic storage > duration. Except it fails to pop when -icount parameter "rr" isn't > given. cur_loc then points to unused stack space, and will most > likely get clobbered in short order. > > Clobbered cur_loc can make loc_pop() and error_print_loc() crash or > report bogus locations. > > Broken in commit 890ad55. > > I didn't take the time to find a reproducer. > > Cc: Eduardo Habkost <ehabk...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > replay/replay.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature