Am 27.04.2016 um 17:51 hat Eric Blake geschrieben:
> On 04/27/2016 03:52 AM, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf <kw...@redhat.com>
> > ---
> > block/bochs.c | 46 +++++++++++++++++++++++++++++-----------------
> > 1 file changed, 29 insertions(+), 17 deletions(-)
> >
>
> > static void bochs_close(BlockDriverState *bs)
> > @@ -267,7 +279,7 @@ static BlockDriver bdrv_bochs = {
> > .instance_size = sizeof(BDRVBochsState),
> > .bdrv_probe = bochs_probe,
> > .bdrv_open = bochs_open,
> > - .bdrv_read = bochs_co_read,
> > + .bdrv_co_preadv = bochs_co_preadv,
> > .bdrv_close = bochs_close,
> > };
>
> Alignment is funky here. I'd rather just get rid of all the extra
> spaces, if that's easier than having half but not all of the = aligned.Alignment is funky by definition when there are tabs involved and new code follows the coding style and uses spaces instead. With a tab stop of 4, this is aligned correctly. The other option would be to just convert the whole struct to spaces, but that's not really related to this patch and I think we're avoiding pure style cleanup patches to keep things like 'git blame' useful. Kevin
pgpDe0KdNMbGm.pgp
Description: PGP signature
