On Thu, 04/28 15:16, Kevin Wolf wrote: > This series introduces a new BlockDriver interface, which will hopefully be > the > final one, or at least good enough for another few years: > .bdrv_preadv/pwritev. > It is based on coroutines, vectored, has flags and uses a byte granularity. > This is now the preferred interface for new drivers. > > All drivers still using the legacy interface .bdrv_read/write are converted to > the new interface and the emulation code we had for the old interface is > removed. Most of the drivers become zero-copy with these patches as they are > vectored now; only vvfat continues to allocate a bounce buffer. > > The less obscure formats (vmdk, vdi, vpc) also natively support byte-aligned > requests now. The block layer is still enforcing a minimal alignment of 512, > so > this isn't actually used yet, but in a next step, we can lift this restriction > for drivers that implement .bdrv_preadv/pwritev.
Code working on byte granularity is consistent and much nicer to read! Though I'm not 100% sure about the compressed write change in VMDK, but there is apparently nothing wrong, too. So: Reviewed-by: Fam Zheng <f...@redhat.com>
