On 04/28/2016 09:00 PM, Zhou Jie wrote: > Files with conditional debug statements should ensure that the printf is > always compiled. > This prevents bitrot of the format string of the debug statement.
Still missing a sentence about the intentional change to use stderr. > > Signed-off-by: Zhou Jie <zhoujie2...@cn.fujitsu.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > --- > v1 -> v2: > * Keep the user-visible witness as defined/undefined, > and create a secondary witness as the actual conditional. > * Switch debug output to stderr. You have it here, but anything after the --- separator gets stripped by 'git am', while we want the change to stderr to be documented as part of the permanent commit log. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
