On Tue, May 3, 2016 at 11:02 PM, Sean Bruno <sbr...@freebsd.org> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > > > On 05/03/16 02:45, haris iqbal wrote: >> Just a reminder. waiting for a review for the previous patch. >> >> On Tue, Apr 5, 2016 at 6:39 PM, Md Haris Iqbal >> <haris.p...@gmail.com> wrote: >>> Signed-off-by: Md Haris Iqbal <haris.p...@gmail.com> --- >>> bsd-user/qemu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 >>> deletions(-) >>> >>> diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index >>> 03b502a..5fac42e 100644 --- a/bsd-user/qemu.h +++ >>> b/bsd-user/qemu.h @@ -357,7 +357,7 @@ static inline void >>> *lock_user(int type, abi_ulong guest_addr, long len, int copy >>> #ifdef DEBUG_REMAP { void *addr; - addr = malloc(len); + >>> addr = g_malloc(len); if (copy) memcpy(addr, g2h(guest_addr), >>> len); else @@ -383,7 +383,7 @@ static inline void >>> unlock_user(void *host_ptr, abi_ulong guest_addr, return; if (len >>> > 0) memcpy(g2h(guest_addr), host_ptr, len); - >>> free(host_ptr); + g_free(host_ptr); #endif } >>> >>> -- 1.9.1 >>> >> >> >> > > If this is the only patch needing review for the bsd-user code, please > put me down as Reviewed by.
Sorry, I am a newbie. Just to confirm, should I send the patch again with "Reviewed by : Sean Bruno" line? > > Reviewed-by: Sean Bruno <sbr...@freebsd.org> > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQF8BAEBCgBmBQJXKOCTXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w > ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx > MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kZE0H/06zauEdcv8Y0K3KI3r2ioFS > M6nqr/UXjqazqIeArBKDC+cnv47cnwH/x6Udn2on+CY9kR91QyUeG/DKUJdEp6Hs > idUuTf3L0W8nhNUUXE9bwVI7H2KWpDzHJ52dnHuSXaQZnBE6Q1AFk0ge+hg+XcCU > BsOqEkTAcxchOnvQJgNpMyXofI35QvSXqqaijTozMdGT7iHG0nKpO6KNW11ash2U > YEVNs9nkr9I+B+qKPhhgX+v4dAuHSekaEstWbkqqSa4YsmqIylL1MNTpRTbEUSEG > fScXKCOy3lANGV6u1sTzLIffR6N3WhkaYCuzYsQ7TQL/TAuYpBrQq7TQt8lb0Do= > =qmUg > -----END PGP SIGNATURE----- -- With regards, Md Haris Iqbal, Placement Coordinator, MTech IT NITK Surathkal, Contact: +91 8861996962