On 5 May 2016 at 04:04, xiaoqiang zhao <zxq_yx_...@163.com> wrote: > * Drop the old SysBus init function and use instance_init > * Move tmu2_glx_init into realize stage > > Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > +static void milkymist_tmu2_realize(DeviceState *dev, Error **errp) > +{ > + MilkymistTMU2State *s = MILKYMIST_TMU2(dev); > + > + if (tmu2_glx_init(s)) { > + error_setg(errp, "tmu2_glx_init failed."); > + } > } The milkymist maintainer might have a suggestion for a more informative error message here. thanks -- PMM