On May 5, 2016, at 10:54 AM, Peter Maydell wrote: > On 24 March 2016 at 14:03, Programmingkid <programmingk...@gmail.com> wrote: >> Add the adb-keys.h file. It maps ADB transition key codes with values. >> >> Signed-off-by: John Arbuckle <programmingk...@gmail.com> >> --- >> *v2 changes: >> Changed order of this patch. >> >> include/hw/input/adb-keys.h | 147 >> ++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 147 insertions(+) >> create mode 100644 include/hw/input/adb-keys.h >> >> diff --git a/include/hw/input/adb-keys.h b/include/hw/input/adb-keys.h >> new file mode 100644 >> index 0000000..633cf71 >> --- /dev/null >> +++ b/include/hw/input/adb-keys.h >> @@ -0,0 +1,147 @@ >> +/* >> + * QEMU System Emulator >> + * >> + * Copyright (c) 2016 John Arbuckle >> + * >> + * This work is licensed under the terms of the GNU GPL, version 2 or later. >> + * See the COPYING file in the top-level directory. >> + */ >> + >> +/* >> + * adb-keys.h >> + * >> + * Provides an enum of all the Macintosh keycodes. >> + * Note: keys like Power, volume related, and eject are handled at a lower >> + * level and are not available to QEMU. That doesn't mean we can't >> + * substitute one key for another. The function keys like F1 make a >> good >> + * substitute for these keys. This can be done in the GTK, SDL, or >> Cocoa >> + * code. > > I don't think this Note makes much sense here, because it's talking about > the UI layer, but this file is just for the keyboard emulation. > > Otherwise > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > > thanks > -- PMM
Thank you for reviewing my patch. Just to sure, you want me to send another patch that has the note removed? If that is the case, I give you full permission to delete the note. That would definitely save us some time.