On Mon, May 02, 2016 at 02:33:32PM +0200, Igor Mammedov wrote: > Machine types before 2.7 have legacy CPU hotplug > enabled by defaut to not regress existing setups > where it's always enabled. > > But since 2.7 CPU hotplug is disabled y default > and requires explicit enabling using 'cpu-hotplug' > parameter in '-machine' option. > So turn it on for cpu-hotplug testcase to allow > it test 2.7 and later machine types. > > Fixes following failure: > > /x86_64/cpu/pc-q35-2.7/add/1x3x2&maxcpus=12: ** > ERROR:tests/pc-cpu-test.c:44:test_pc_with_cpu_add: > assertion failed: (!qdict_haskey(response, "error"))
Is this test error introduced by a patch in this series? If so, shouldn't this fix be squashed with the patch that disables CPU hotplug by default, so we get a bisectable tree? -- Eduardo
