On Fri, Jun 25, 2010 at 06:53:22PM +0200, Markus Armbruster wrote: > All callers of ide_create_drive() ignore its value. Currently > harmless, because it fails only when qdev_init() fails, which fails > only when ide_drive_initfn() fails, which never fails. > > Brittle. Change it to die instead of silently ignoring failure. > > Signed-off-by: Markus Armbruster <arm...@redhat.com>
Looks good, Reviewed-by: Christoph Hellwig <h...@lst.de>
