On Fri, Jun 25, 2010 at 06:53:26PM +0200, Markus Armbruster wrote: > Make the property point to BlockDriverState, cutting out the DriveInfo > middleman. This prepares the ground for block devices that don't have > a DriveInfo. > > Currently all user-defined ones have a DriveInfo, because the only way > to define one is -drive & friends (they go through drive_init()). > DriveInfo is closely tied to -drive, and like -drive, it mixes > information about host and guest part of the block device. I'm > working towards a new way to define block devices, with clean > host/guest separation, and I need to get DriveInfo out of the way for > that. > > Fortunately, the device models are perfectly happy with > BlockDriverState, except for two places: ide_drive_initfn() and > scsi_disk_initfn() need to check the DriveInfo for a serial number set > with legacy -drive serial=... Use drive_of_blockdev() there. > > Device model code should now use DriveInfo only when explicitly > dealing with drives defined the old way, i.e. without -device.
This looks good to me. Assuming the size change of the property can't cause any problems: Reviewed-by: Christoph Hellwig <h...@lst.de>
