On 13 May 2016 at 08:56, Gerd Hoffmann <kra...@redhat.com> wrote: >> > This was on ppc64be Linux, though I'm guessing that's just because >> > it's the only system that happens not to define CONFIG_VTE. >> >> mingw builds don't have vte too, so I'm wondering now how that one >> managed to escape my attention ... > > Ah, because only linux builds default to -Werror. > > Maybe we should change that? mingw builds without warnings these days > for me (which wasn't the case a while ago, which in turn is probably the > reason for the selective -Werror).
It depends a bit on your config (I have to add -Wno-unused-local-typedefs to work around a glib header warning), but yes, arguably we should (my pre-merge build configs for w32 do use -Werror). thanks -- PMM
