On Thu, May 12, 2016 at 10:51:43AM +0300, Michael S. Tsirkin wrote: > On Thu, May 12, 2016 at 03:32:03PM +0800, Peter Xu wrote: [...] > > > Are there cases where we need the original requester id value? > > > I am guessing not, and if I'm right we should just change the > > > implementation > > > of pci_requester_id to DTRT. > > > > There are two other callers for it (besides the MSI one): > > > > - assigned_device_pci_cap_init()
This should use the new interface. > > - do_pcie_aer_inject_error() This should use the old one, which is to get BDF only. > > > > For both the cases, I am not sure whether we can do the replacement. > > > > -- peterx > > Read the specs please. We can't just pile on APIs. IIUC, we may still need to add a new API here, because not all of them are looking for requester IDs. I just posted v2 for this patch. Instead of renaming the new function, I renamed the old one to pci_get_bdf(). Hope that works. Thanks, -- peterx
