On 06/28/10 18:20, Blue Swirl wrote: > On Mon, Jun 28, 2010 at 4:03 PM, Jes Sorensen <jes.soren...@redhat.com> wrote: >> Yeah, the problem with tying it to CONFIG_LINUX is that older version of >> Linux may not support it. Looking through the list, MAP_POPULATE is >> really an oddball in there though, so maybe it would be cleaner to catch >> it via configure and then use CONFIG_MAP_POPULATE or something like that? > > There'd be 1:1 relation between MAP_POPULATE and CONFIG_MAP_POPULATE, > so maybe not.
That is correct, but CONFIG_MAP_POPULATE would be in config.h so it would not get missed out in cases where someone includes qemu-options.h without including sys/mmap.h first. But it is a corner case, so my patch should be fine. Cheers, Jes
