On Wed, 05/18 08:25, Eric Blake wrote: > On 05/17/2016 11:53 PM, Fam Zheng wrote: > > Otherwise the job is orphaned and block_job_cancel_sync in > > bdrv_close_all() when quiting will hang. > > s/quiting/quitting/ > > > > > A simple reproducer is running blockdev-backup from null-co:// to > > null-co://. > > Worth a qemu-iotests addition?
Sure, as you asked, will send one in addition. Fam > > > > > Cc: qemu-sta...@nongnu.org > > Signed-off-by: Fam Zheng <f...@redhat.com> > > --- > > block/backup.c | 34 ++++++++++++++++++---------------- > > 1 file changed, 18 insertions(+), 16 deletions(-) > > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >