On Tue, 05/31 16:27, Alex Bennée wrote: > > Fam Zheng <f...@redhat.com> writes: > > > On Thu, 05/26 15:27, Alex Bennée wrote: > >> Together with some changes to the docker script you can now build an > >> arbitrary architecture of Debian using debootstrap. To achieve this I > >> introduce the concept of a HOST_CMD in the docker config file. While > >> copying the file into workspace the HOST_CMD is run in the docker build > >> context. This allows debootstrap to set up its first stage before the > >> container is built. > > > > Could you instead introduce the concept of $IMAGE.pre file (in this case > > debian-bootstrap.pre, aside debian-bootstrap.docker), and exec it in > > docker.py? It would be much more flexible, and we we wouldn't need to > > inject a > > custom directive to filter it out. > > I'm ambivalent about that. To be honest this is a bit of a gap in > docker's image creation (or if there is a better more docker-y way of > doing things I couldn't find it). It does have the benefit of keeping > everything in one place.
I don't like that it pollutes the dockerfile, rendering it invalid for raw "docker build", which is not very good. > > We are copying the dockerfile to the build environment anyway so it > seemed natural to do the operation while copying across. How would > envison the .pre setup? A #! script we just exec inside the temp > directory we create? Yes, since I'm going to send a v7, I'll merge the tmp dir part in to my series, and add a new patch for the "pre" idea to see if we like it. Fam
