On Thu, Jun 02, 2016 at 12:06:59PM +0200, Igor Mammedov wrote: > On Wed, 1 Jun 2016 15:54:50 -0300 > Eduardo Habkost <ehabk...@redhat.com> wrote: [...] > > > -static void cpu_common_parse_features(CPUState *cpu, char > > > *features, +static void cpu_common_parse_features(const char > > > *typename, char *features, Error **errp) > > > { > > > char *featurestr; /* Single "key=value" string being parsed */ > > > char *val; > > > - Error *err = NULL; > > > + static bool cpu_globals_initialized; > > > + > > > + if (cpu_globals_initialized) { > > > + return; > > > + } > > > > Should we replace this with assert(!cpu_globals_initialized) > > after applying patch 8/8? > assert might potentially break cpu_init() users, so I went safest route > here.
No problem: we can add an assert() after fixing the cpu_init() users, if necessary (we have only two of them). -- Eduardo