On Tue, 2016-05-31 at 14:59 +0200, Paolo Bonzini wrote: > > On 31/05/2016 09:03, Robert Ho wrote: > > I find that '-vnc' option actually has a parameter 'to', implicitly; > > while actually is there and can be used but not be public. > > Don't know why but this may probably confuse user, especially when used in > > some default situation implicitly. > > > > So shall I? > > 1. Add its description in QEMU manual info > > 2. Expilicitly print out when it's used with non-default value > > I think patch 1 is okay.
Thanks Paolo. Sorry for late reply, since I just part-time work on this. > > For patch 2, I am not sure I see the point of printing the VNC options; > the VNC port is printed immediately after. I agree it is not significantly meaningful to print out the options. I just disliked the implicitly be-on-behalf-chose a value without notification; especially we don't know there is a 'to' option. So when I did the density test of huge quantity of guests, always failed on 99th, made me quizzical. :( In most ordinary cases, the final 'VNC server running on ...' printf is sufficient. Now my that emotion gradually die out, I agree abandon patch 2. :) > > However, I think it is useful to print the VNC port whenever the user > specifies "-vnc to=XX". Perhaps you could move show_vnc_port (the > variable, the assignments and the "if (show_vnc_port)") from vl.c to > vnc_display_open? And 2nd reason I abandon patch 2: I grepped in vnc.c, no bare 'printf'. Any nice wrapper for such info purpose? I don't want to be first 'bad guy' to break the elegant code. ;) So do I need to send out v2 patch? which simply contains single patch 1. > > Thanks, > > Paolo
