On 06/06/2016 03:37 AM, Michael Rolnik wrote:
changes since v3 1. rampD/X/Y/Z registers are encoded as 0x00ff0000 and not 0x000000ff for faster address manipulaton 2. ffs changed to ctz32 3. duplicate code removed at avr_cpu_do_interrupt 4. using andc instead of not + and 5. fixing V flag calculation in varios instructions 6. freeing local variables in PUSH 7. tcg_const_local_i32 -> tcg_const_i32 8. using sextract32 instead of my implementation 9. fixing BLD instruction 10.xor(r) instead of 0xff - r at COM 11.fixing MULS/MULSU not to modify inputs' content 12.using SUB for NEG 13.fixing tcg_gen_qemu_ld/st call in XCH
I did mention the numerous checkpatch warnings: $ ./scripts/checkpatch.pl avr-patches-4/* | grep total: total: 0 errors, 16 warnings, 1142 lines checked total: 0 errors, 0 warnings, 422 lines checked total: 0 errors, 3 warnings, 343 lines checked total: 0 errors, 4 warnings, 730 lines checked total: 0 errors, 1 warnings, 69 lines checked total: 0 errors, 0 warnings, 199 lines checked total: 0 errors, 18 warnings, 724 lines checked total: 0 errors, 240 warnings, 2619 lines checked total: 0 errors, 1 warnings, 176 lines checked $ ./scripts/checkpatch.pl avr-patches-4/* | grep WARNING: | sort -u WARNING: architecture specific defines should be avoided WARNING: externs should be avoided in .c files WARNING: line over 80 characters WARNING: space prohibited between function name and open parenthesis '(' WARNING: struct MemoryRegionOps should normally be const WARNING: struct VMStateDescription should normally be const r~