Kevin Wolf <kw...@redhat.com> writes: > Am 30.06.2010 13:55, schrieb Markus Armbruster: >> drive_init() doesn't permit rerror for if=scsi, but that's worthless: >> we get it via if=none and -device. >> >> Moreover, scsi-generic doesn't support werror. Since drive_init() >> doesn't catch that, option werror was silently ignored even with >> if=scsi. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > It's still not entirely right, of course. You can explicitly request > werror=enospc and the VM will start successfully, but silently ignore > ENOSPC errors.
Yes, I took a shortcut here :) Obvious fix is a separate default action. Drivers supporting werror interpret it as "enospc". Drivers not supporting werror interpret it as "do nothing", and reject any other option. Similar for rerror. > Anyway, it's better than before.