On 03/06/2016 17:57, Radim Krčmář wrote: >> > + cenv->msr_ia32_feature_control |= >> > + MSR_IA32_FEATURE_CONTROL_LMCE | >> > + MSR_IA32_FEATURE_CONTROL_LOCKED; > Locking right from the start breaks nested KVM, because nested relies on > setting VMXON feature from inside of the guest. > > Do we keep it unlocked, or move everything into QEMU? > > (The latter seems simpler.)
I think it should be moved into the firmware, with QEMU publishing the desired setting via fw_cfg. The same as what is done in real hardware, that's the KVM mantra. :) For v4 it's okay to just remove this. Paolo
