On 10 June 2016 at 16:05, Eric Blake <ebl...@redhat.com> wrote: > On 06/10/2016 09:01 AM, Peter Maydell wrote: >> The *_to_cpup() functions just compose a pointer dereference with >> a *_to_cpu() byteswap. Instead use ld*_p(), which handles potential >> pointer misaligment and avoids the need to cast the pointer. > > s/misaligment/misalignment/ > >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> The motivation here is that I'd like to get rid of _to_cpup() >> entirely: we don't have many places that use it. >> --- >> migration/migration.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> > > Reviewed-by: Eric Blake <ebl...@redhat.com>
Thanks. I just noticed that I missed the use of cpu_to_be64w() for loads, so I'll send a v2. -- PMM
