On 06/11/2016 08:58 PM, Fam Zheng wrote: >>> - return ret; >>> + return bs->drv->bdrv_co_pwritev(bs, qcow2_vm_state_offset(s) + pos, >>> + qiov->size, qiov, 0); >>> } >> >> bs->drv->bdrv_co_pwritev() is an optional interface; not all the drivers >> have it yet. Should you be asserting that it exists, and/or returning >> an error if it does not? > > bs->drv is always qcow2 driver here so this is correct.
In that case, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
