On 06/15/2016 02:41 PM, Markus Armbruster wrote:
> Range encodes an integer interval [a,b] as { begin = a, end = b + 1 },
> where a \in [0,2^64-1] and b \in [1,2^64]. Thus, zero end is to be
> interpreted as 2^64.
>
> The implementation of -dfilter (commit 3514552) uses Range
> differently: it encodes [a,b] as { begin = a, end = b }. The code
> works, but it contradicts the specification of Range in range.h.
>
> Switch to the specified representation. Since it can't represent
> [0,UINT64_MAX], we have to reject that now. Add a test for it.
>
> While we're rejecting anyway: observe that we reject -dfilter LOB..UPB
> where LOB > UPB when UPB is zero, but happily create an empty Range
> when it isn't. Reject it then, too, and add a test for it.
>
> While there, add a positive test for the problematic upper bound
> UINT64_MAX.
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> tests/test-logging.c | 10 ++++++++++
> util/log.c | 28 +++++++++++++++-------------
> 2 files changed, 25 insertions(+), 13 deletions(-)
> Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
