Eduardo Habkost <ehabk...@redhat.com> writes: > qdev_prop_set_globals_for_type() stops applying global properties > on the first error. It is a leftover from when QEMU exited on any > error when applying global property. Now we print a warning about > the first error, bug ignore all other global properties after it.
Might want to add "Messed up in commit 25f8dd9." > For example, the following command-line will not set CPUID level > to 3, but will warn only about "x86_64-cpu.vendor" being ignored. > > $ ./x86_64-softmmu/qemu-system-x86_64 \ > -global x86_64-cpu.vendor=x \ > -global x86_64-cpu.level=3 > qemu-system-x86_64: Warning: global x86_64-cpu.vendor=x ignored: Property > '.vendor' doesn't take value 'x' > > Fix this by not returning from qdev_prop_set_globals_for_type() > on the first error. > > Cc: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> Reviewed-by: Markus Armbruster <arm...@redhat.com>
