This patch is about NaN-2008 flavor of Mips instructions CEIL, CVT, FLOOR, ROUND, TRUNC only (its title is "Add nan2008 flavor...").
Legacy-NaN flavors of the same Mips instructions already operate correctly, and there is nothing to be fixed. The commit message is not description of another bug, it explains the context of the change, and the content of added code segments. ________________________________________ From: Maciej Rozycki Sent: Tuesday, June 14, 2016 8:30 AM To: Leon Alrae Cc: Aleksandar Markovic; Aleksandar Markovic; qemu-devel@nongnu.org; peter.mayd...@linaro.org; pro...@gmail.com; kbast...@mail.uni-paderborn.de; mark.cave-ayl...@ilande.co.uk; ag...@suse.de; blauwir...@gmail.com; jcmvb...@gmail.com; qemu-...@nongnu.org; qemu-...@nongnu.org; Petar Jovanovic; pbonz...@redhat.com; Miodrag Dinic; edgar.igles...@gmail.com; g...@mprc.pku.edu.cn; afaer...@suse.de; Aurelien Jarno; r...@twiddle.net Subject: Re: [PATCH v6 8/9] target-mips: Add nan2008 flavor of <CEIL|CVT|FLOOR|ROUND|TRUNC>.<L|W>.<S|D> On Tue, 14 Jun 2016, Leon Alrae wrote: > > 1. A bug fix for SoftFloat legacy-NaN (original) MIPS support, which has > > been there probably since forever (i.e. since the MIPS target was added > > to QEMU). > > I've just done another round of review and as far as I can tell these > patches don't modify the legacy-NaN MIPS behaviour. I believe Aleksandar > was referring to new functionality (i.e. 2008 NaN) only. Well, if there's a bug, then it needs to be fixed rather than documented. Maciej