On 20/06/16 16:02, Alex Bennée wrote: > Sergey Fedorov <sergey.fedo...@linaro.org> writes: > >> > From: Alex Bennée <alex.ben...@linaro.org> >> > >> > CPUState is a fairly common pointer to pass to these helpers. This means >> > if you need other arguments for the async_run_on_cpu case you end up >> > having to do a g_malloc to stuff additional data into the routine. For >> > the current users this isn't a massive deal but for MTTCG this gets >> > cumbersome when the only other parameter is often an address. >> > >> > This adds the typedef run_on_cpu_func for helper functions which has an >> > explicit CPUState * passed as the first parameter. All the users of >> > run_on_cpu and async_run_on_cpu have had their helpers updated to use >> > CPUState where available. >> > >> > Signed-off-by: Alex Bennée <alex.ben...@linaro.org> >> > Signed-off-by: Sergey Fedorov <sergey.fedo...@linaro.org> > Is this as is or did you apply the fixes from the review comments? > It's "as is" so far. I could take charge of this patch in some later re-spin.
Kind regards, Sergey
