Am 22.06.2016 um 14:25 hat Alberto Garcia geschrieben: > find_block_job() looks for a block backend with a specified name, > checks whether it has a block job and acquires its AioContext. This > patch uses block_job_next() and iterate directly over the block jobs. > > In addition to that we want to identify jobs primarily by their ID, so > this patch updates find_block_job() to allow IDs too. Only one of ID > and device name can be specified when looking for a block job. > > Signed-off-by: Alberto Garcia <be...@igalia.com>
Nice, this gets rid of another bs->job user. But as I said in patch 2, it's better to leave out the device thing. We can just update the documentation of the QMP commands so that 'device' contains a job ID rather than a device name and then we can look up IDs unconditionally. This will simplify the function even more. Kevin
