On Thu, Jun 23, 2016 at 10:26:49AM +0200, Markus Armbruster wrote: > Eduardo Habkost <ehabk...@redhat.com> writes: > > > MachineClass::compat_props may point to class names that are not > > compiled into the QEMU binary. Skip registering those as global > > properties. This will allow the qdev global property code to > > implement stricter checks on the global property values in the > > future. > > > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > Not sure what those stricter checks might be, but that's okay. > > Doesn't this suppress detection of programming errors? Say I fat-finger > a device name in my machine type's global properties.
We can't detect that, because compat_props is allowed to include classes that are disabled at build time. > Before this patch, I get an error (a nice one since PATCH 06). You don't. The class name validation in qdev_prop_check_globals() is done only on user-provided properties. -- Eduardo
