On Fri, Jun 24, 2016 at 02:08:52PM +0200, Marc-André Lureau wrote: > On Thu, Jun 23, 2016 at 7:01 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > >> > Maybe what you want is a need_unlink feature. > >> > Set it for unix sockets only, that would make some sense. > >> > >> Oh perhaps what you mean is that if the fd was passed, we should cleanup > >> the unix socket? Yes, I think we should do that then. I'll update the > >> series. > > Actually it's not possible to pass a listening fd to a socket chardev > today (the path argument doesn't understand /dev/fdset), so only path > created by qemu will be cleaned up. > > > > > I'd like it better contained - that's all. So let's set a flag that says > > "must unlink" as opposed to "it's listening". > > You suggest to rename QIO_CHANNEL_FEATURE_LISTEN to > QIO_CHANNEL_FEATURE_LISTEN_MUST_UNLINK ? Or to add another feature > flag? I don't think that brings anything useful here.
IMHO the existing QIO_CHANNEL_FEATURE_LISTEN makes more sense than a QIO_CHANNEL_FEATURE_MUST_UNLINK, so I'd like to see your current patches go in as is. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
