Igor Mammedov <imamm...@redhat.com> writes:
> replace mainly useless exit(1) on fatal error path with
> abort(), so that it would be possible to generate core
> dump, that could be used to analyse cause of problem.
>
> Signed-off-by: Igor Mammedov <imamm...@redhat.com>
> ---
> hw/virtio/virtio.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index 7ed06ea..9d3ac72 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -315,7 +315,7 @@ static int virtqueue_num_heads(VirtQueue *vq, unsigned
> int idx)
> if (num_heads > vq->vring.num) {
> error_report("Guest moved used index from %u to %u",
> idx, vq->shadow_avail_idx);
> - exit(1);
> + abort();
What's wrong with a simple assert(num_heads <= vq->vring.num)?
> }
> /* On success, callers read a descriptor at vq->last_avail_idx.
> * Make sure descriptor read does not bypass avail index read. */
[...]
