On 01.07.2016 17:52, Alberto Garcia wrote: > When a new job is created, the job ID is taken from the device name of > the BDS. This patch adds a new 'job_id' parameter to let the caller > provide one instead. > > This patch also verifies that the ID is always unique and well-formed. > This causes problems in a couple of places where no ID is being set, > because the BDS does not have a device name. > > In the case of test_block_job_start() (from test-blockjob-txn.c) we > can simply use this new 'job_id' parameter to set the missing ID. > > In the case of img_commit() (from qemu-img.c) we still don't have the > API to make commit_active_start() set the job ID, so we solve it by > setting a default value. We'll get rid of this as soon as we extend > the API. > > Signed-off-by: Alberto Garcia <be...@igalia.com> > --- > block/backup.c | 3 ++- > block/commit.c | 2 +- > block/mirror.c | 2 +- > block/stream.c | 2 +- > blockjob.c | 29 +++++++++++++++++++++++++---- > include/block/blockjob.h | 8 +++++--- > tests/test-blockjob-txn.c | 7 +++++-- > 7 files changed, 40 insertions(+), 13 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
