On 02/07/2016 09:38, Sergey Fedorov wrote: >>>> >>> +bool qemu_tcg_mttcg_enabled(void) >>>> >>> +{ >>>> >>> + return mttcg_enabled; >>>> >>> +} >>> >> Is there a good reason to expose this via function call, rather than >>> >> just test >>> >> the variable? >> > It was in Fred's original patch. I guess there could be an argument >> > versus a global variable but as mttcg_enabled is set during option >> > parsing we don't need to do anything dynamic. > I think it just resembles tcg_enabled(), kvm_enabled() etc.
Those are macros however, not functions. They are macros in order to cull KVM code for files that are compiled per-target. Paolo