Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] std: add cp437 to unicode map

[Kevin O'Connor]

On Mon, Jul 04, 2016 at 10:39:52PM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>

Nice!

[...]
> --- /dev/null
> +++ b/src/std/cp437.h

Instead of making a header file and including it in an array in the C
code I think it would be better to instead introduce cp437.c with:

u16 sercon_cp437[256] VARFSEG = {
   ...
};

[...]
> +[ 0x7f ] = 0x007f, //  DELETE

That should be 0x2302 (see the wikipedia page).

-Kevin