On 07/05/2016 07:11 AM, Daniel P. Berrange wrote: > The opts-visitor.c opts_type_bool() method has code for > parsing a string to set a bool value, as does the > qemu-option.c parse_option_bool() method, except it > handles fewer cases. > > To enable consistency across the codebase, extend > parse_option_bool() to handle "yes", "no", "y" and > "n", and make it non-static. Convert the opts > visitor to call this method directly. > > Also make parse_option_number() non-static to allow > for similar reuse later. > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > include/qemu/option.h | 4 ++++ > qapi/opts-visitor.c | 19 +------------------ > util/qemu-option.c | 27 ++++++++++++++++----------- > 3 files changed, 21 insertions(+), 29 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> I'm going to include this in my proposed fallback patches on my qapi subset F series, where we may need to "fix" netdev_add to care about back-compat parsing of a string where an integer is expected. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
