On 07/14/2016 07:10 AM, Cao jin wrote: > replace tab with spaces > > Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> > --- > async.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Whitespace-only changes are best done as part of a series that is already touching nearby code for other reasons (depending on the size of the whitespace changes and on the rest of your patch, it may be okay to squash the whitespace change in place, or better to split into separate patches to make review of both patches easier). Otherwise, it just makes 'git blame' output dirtier. > > diff --git a/async.c b/async.c > index 1f9754b..8589017 100644 > --- a/async.c > +++ b/async.c > @@ -217,7 +217,7 @@ aio_ctx_check(GSource *source) > for (bh = ctx->first_bh; bh; bh = bh->next) { > if (!bh->deleted && bh->scheduled) { > return true; > - } > + } Nothing wrong with the patch itself, and I won't oppose it going in, but it's generally not worth the effort if nothing else in this file needs fixing. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature