On 07/14/2016 12:07 PM, Eric Blake wrote: > On 07/14/2016 06:29 AM, Denis V. Lunev wrote: >> From: Evgeny Yakovlev <eyakov...@virtuozzo.com> >> >> Due to skipped flushes on bdrv_co_flush BLOCK_JOB_READY events >> for driver-mirror and active block-commit commands now arrives faster, >> before QMP send successfully returns to caller. >> >> This change expects for block job ready event to arrive before >> QMP send successfully returns in block tests 141 144 >> >> Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> >> Signed-off-by: Denis V. Lunev <d...@openvz.org> >> CC: Kevin Wolf <kw...@redhat.com> >> CC: Max Reitz <mre...@redhat.com> >> CC: Stefan Hajnoczi <stefa...@redhat.com> >> CC: Fam Zheng <f...@redhat.com> >> CC: John Snow <js...@redhat.com> >> --- >> tests/qemu-iotests/141.out | 4 ++-- >> tests/qemu-iotests/144.out | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) > > Same comment as in 5/6: if the testsuite broke as a result of 4/6, then > this should be squashed in to that patch so that the end result of your > series never lands on a bisection point where the testsuite is broken. > >
Yes, please: all patches must be ordered such that intermediate commits do not break iotests or 'make check'. (Sorry for the runaround.) --js
