On 14.07.2016 22:44, Eric Blake wrote: > On 07/14/2016 07:28 AM, Kevin Wolf wrote: >> In order to remove the necessity to use BlockBackend names in the >> external API, we want to allow node-names everywhere. This converts >> change-backing-file to accept a node-name without lifting the >> restriction that we're operating at a root node. >> >> In case of an invalid device name, the command returns the GenericError >> error class now instead of DeviceNotFound, because this is what >> qmp_get_root_bs() returns. >> >> Signed-off-by: Kevin Wolf <kw...@redhat.com> >> --- >> blockdev.c | 15 +++------------ >> qapi/block-core.json | 3 ++- >> qmp-commands.hx | 3 ++- >> 3 files changed, 7 insertions(+), 14 deletions(-) >> > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > Sometimes I wonder why this command is limited to only the root node - > it seems like tweaking the backing file text of an intermediate node in > a chain would be useful to someone. But that's not the problem for this > series.
Is it? The main argument of change-backing-file is not @device but @image-node-name. @device is just used for a sanity check. Max
signature.asc
Description: OpenPGP digital signature